Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wacom overlay visible #2198

Merged
merged 2 commits into from Jun 4, 2020
Merged

Make wacom overlay visible #2198

merged 2 commits into from Jun 4, 2020

Conversation

Feichtmeier
Copy link
Member

Style .button with %button and use osd colors for the window

Screenshot from 2020-06-01 11-05-35

@madsrh @clobrano they want to fix it for 3.38 I think (looking at their tags), and since I think this bug should be fixed as soon as possible for 20.04 wacom users, let's get this in?

Closes #2099

Style .button with %button and use osd colors for the window
@Feichtmeier
Copy link
Member Author

Ps.: the button at the bottom is an "insensitive" shell button. I am not sure if we should maybe change all insensitive shell buttons to look better, but I have no idea how to test this outside of this dialogue

@clobrano
Copy link
Member

clobrano commented Jun 1, 2020

I agree this shall get in as soon as possible, but I can't test this as well :(

@madsrh
Copy link
Member

madsrh commented Jun 1, 2020

+1 we need this fixed for the LTS

If you have a fix for the "insensitive" button that would be great :)

@Feichtmeier
Copy link
Member Author

Btw the weird position is fixed in 3.36 shell and will land in Ubuntu some day

Regarding the insensitive button, this is how they look in the auth dialog
grafik

@Feichtmeier
Copy link
Member Author

@madsrh somehow they behave differently than in dialogues and have some strange fog-like stuff overlayed above them
We could try to strengthen the text color a bit for those wacom buttons
grafik
Would this be okay?

@Feichtmeier
Copy link
Member Author

Cool, dark shell also works. 👍
@clobrano proceed as you wish ^^ I've lost orientation of releases and so on

@clobrano
Copy link
Member

clobrano commented Jun 4, 2020

Merging then 👍

@clobrano clobrano merged commit 70462d9 into master Jun 4, 2020
@clobrano clobrano deleted the ShellTheme_wacom branch June 4, 2020 06:27
@@ -34,7 +34,7 @@ $tooltip_borders_color: $osd_outer_borders_color;
$shadow_color: transparentize(black, 0.9);

//insensitive state derived colors
$insensitive_fg_color: mix($fg_color, $bg_color, 50%);
$insensitive_fg_color: mix($fg_color, $bg_color, 70%);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man, this happens if you do too much in one time. Did not want to commit this @clobrano , sorry.
WIll make a PR for this specific line later

Feichtmeier added a commit that referenced this pull request Jun 4, 2020
This reverts insensitive_fg_color to the previous value before #2198
Feichtmeier added a commit that referenced this pull request Jun 5, 2020
Feichtmeier added a commit that referenced this pull request Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text in Wacom "Map buttons" is unreadable
3 participants