Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting icon-changes from groovy to focal #2506

Closed
wants to merge 6 commits into from
Closed

backporting icon-changes from groovy to focal #2506

wants to merge 6 commits into from

Conversation

Muqtxdir
Copy link
Member

@Muqtxdir Muqtxdir commented Dec 12, 2020

hi,
this PR is for #2505 (LP#1907844)

added files

fullcolor/mimetypes (20 files):

  • /icons/src/fullcolor/mimetypes/application-pgp-encrypted.svg
  • /icons/src/fullcolor/mimetypes/application-pgp-keys.svg
  • /icons/src/fullcolor/mimetypes/application-pgp-signature.svg
  • /icons/src/fullcolor/mimetypes/application-x-gzip.svg
  • /icons/src/fullcolor/mimetypes/application-x-musescore3.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-hdd.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-ova.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-ovf.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-vbox.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-vbox-extpack.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-vdi.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-vhd.svg
  • /icons/src/fullcolor/mimetypes/application-x-virtualbox-vmdk.svg
  • /icons/src/fullcolor/mimetypes/html-template.svg
  • /icons/src/fullcolor/mimetypes/rom.svg
  • /icons/src/fullcolor/mimetypes/text-dockerfile.svg
  • /icons/src/fullcolor/mimetypes/text-x.gcode.svg
  • /icons/src/fullcolor/mimetypes/text-x-gettext-translation-template.svg
  • /icons/src/fullcolor/mimetypes/text-x-patch.svg
  • /icons/src/fullcolor/mimetypes/text-x-maven+xml.svg

scalable/actions (28 files):

  • /icons/Suru/scalable/actions/detach-symbolic.svg
  • /icons/Suru/scalable/actions/edit-symbolic.svg
  • /icons/Suru/scalable/actions/font-color-symbolic.svg
  • /icons/Suru/scalable/actions/font-size-symbolic.svg
  • /icons/Suru/scalable/actions/format-ordered-list-symbolic.svg
  • /icons/Suru/scalable/actions/format-ordered-list-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/format-text-remove-symbolic.svg
  • /icons/Suru/scalable/actions/format-toolbar-toggle-symbolic.svg
  • /icons/Suru/scalable/actions/format-unordered-list-symbolic.svg
  • /icons/Suru/scalable/actions/format-unordered-list-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/globe-centered-symbolic.svg
  • /icons/Suru/scalable/actions/mail-archive-symbolic.svg
  • /icons/Suru/scalable/actions/mail-drafts-symbolic.svg
  • /icons/Suru/scalable/actions/mail-drafts-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/mail-forward-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/mail-inbox-symbolic.svg
  • /icons/Suru/scalable/actions/mail-outbox-symbolic.svg
  • /icons/Suru/scalable/actions/mail-reply-sender-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/mail-sent-symbolic.svg
  • /icons/Suru/scalable/actions/mail-sent-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/marker-symbolic.svg
  • /icons/Suru/scalable/actions/selection-symbolic.svg
  • /icons/Suru/scalable/actions/system-run-symbolic.svg
  • /icons/Suru/scalable/actions/tag-symbolic.svg
  • /icons/Suru/scalable/actions/tag-symbolic-rtl.svg
  • /icons/Suru/scalable/actions/tools-check-spelling-symbolic.svg
  • /icons/Suru/scalable/actions/view-layout-symbolic.svg
  • /icons/Suru/scalable/actions/window-symbolic.svg

scalable/apps (3 files):

  • /icons/Suru/scalable/apps/gnome-disks-state-standby-symbolic.svg
  • /icons/Suru/scalable/apps/og.gnome.Shotwell-symbolic.svg
  • /icons/Suru/scalable/apps/ubuntusoftware-symbolic.svg

scalable/devices (1 file):

  • /icons/Suru/scalable/devices/display-symbolic.svg

scalable/status (4 files):

  • /icons/Suru/scalable/status/alarm-centered-symbolic.svg
  • /icons/Suru/scalable/status/video-joined-displays-symbolic.svg
  • /icons/Suru/scalable/status/video-single-display-symbolic.svg
  • /icons/Suru/scalable/status/view-mirror-symbolic.svg

modified-files

fullcolor/mimetypes (16 files):

  • /icons/src/fullcolor/mimetypes/application-vnd.snap.svg
  • /icons/src/fullcolor/mimetypes/application-vnd.squashfs.svg
  • /icons/src/fullcolor/mimetypes/application-x-7z-compressed.svg
  • /icons/src/fullcolor/mimetypes/application-x-apple-diskimage.svg
  • /icons/src/fullcolor/mimetypes/application-x-cd-image.svg
  • /icons/src/fullcolor/mimetypes/application-x-executable.svg
  • /icons/src/fullcolor/mimetypes/application-x-gzip.svg
  • /icons/src/fullcolor/mimetypes/application-x-karbon.svg
  • /icons/src/fullcolor/mimetypes/application-x-krita.svg
  • /icons/src/fullcolor/mimetypes/application-x-model.svg
  • /icons/src/fullcolor/mimetypes/application-x-ms-dos-executable.svg
  • /icons/src/fullcolor/mimetypes/application-x-rar.svg
  • /icons/src/fullcolor/mimetypes/application-x-raw-disk-image.svg
  • /icons/src/fullcolor/mimetypes/application-x-zip.svg
  • /icons/src/fullcolor/mimetypes/image-x-generic.svg
  • /icons/src/fullcolor/mimetypes/image-x-xcf.svg

fullcolor/apps (1 file):

  • /icons/src/fullcolor/apps/ubiquity.svg

fullcolor/places (1 file):

  • /icons/src/fullcolor/places/folders.svg

scalable/actions (5 files):

  • /icons/Suru/scalable/actions/bookmark-new-symbolic.svg
  • /icons/Suru/scalable/actions/document-new-symbolic.svg
  • /icons/Suru/scalable/actions/insert-image-symbolic.svg
  • /icons/Suru/scalable/actions/view-dual-symbolic.svg
  • /icons/Suru/scalable/actions/window-new-symbolic.svg

scalable/apps (1 file):

  • /icons/Suru/scalable/apps/application-x-executable-symbolic.svg

scalable/categories (3 files):

  • /icons/Suru/scalable/categories/accessories-dictionary-symbolic.svg
  • /icons/Suru/scalable/categories/applications-graphics-symbolic.svg

scalable/emblems (3 files):

  • /icons/Suru/scalable/emblems/emblem-documents-symbolic.svg
  • /icons/Suru/scalable/emblems/emblem-photos-symbolic.svg

scalable/mimetypes (3 files):

  • /icons/Suru/scalable/mimetypes/image-x-generic-symbolic.svg
  • /icons/Suru/scalable/mimetypes/text-x-generic-symbolic.svg
  • /icons/Suru/scalable/mimetypes/x-office-document-symbolic.svg

scalable/places (2 files):

  • /icons/Suru/scalable/places/folder-documents-symbolic.svg
  • /icons/Suru/scalable/places/folder-pictures-symbolic.svg
  • /icons/Suru/scalable/places/user-bookmarks-symbolic.svg

deleted files

fullcolor/mimetypes (1 file):
/icons/src/fullcolor/mimetypes/application-x-gameboy-rom.svg

thanks!

@Muqtxdir Muqtxdir marked this pull request as ready for review December 12, 2020 09:33
@Feichtmeier
Copy link
Member

Thanks @Muqtxdir !
I'll set up a focal VM and test this branch

@Feichtmeier Feichtmeier self-requested a review December 22, 2020 10:34
@Feichtmeier
Copy link
Member

@Muqtxdir checked your PR looking great 👍

Did #2375 land in groovy?
If yes I think it's missing :)
grafik

@Muqtxdir
Copy link
Member Author

sorry @Feichtmeier, I've added now symlinks from #2375 to emblems and also for devices

@Feichtmeier
Copy link
Member

grafik
Now they are in thanks 👍

@Feichtmeier
Copy link
Member

I wonder if we could extend this to a general icon upgrade from master for focal, especially if hirsute won't receive any gnome-shell or gtk3 changes
WDYT @didrocks ?

@Feichtmeier Feichtmeier added this to In progress in Yaru via automation Feb 1, 2021
@Muqtxdir
Copy link
Member Author

Muqtxdir commented Feb 6, 2021

@Feichtmeier just read your comments from launchpad.
since the folded-mimetypes will be coming to hirsute should I also do them here on focal-branch as well or do we wait till it comes to hirsute first?

@Feichtmeier
Copy link
Member

I'll say let's wait a bit more with backporting until the SRU people answered. And yes this means let's wait until master is in hirsute

@Feichtmeier Feichtmeier marked this pull request as draft February 18, 2021 16:56
@Feichtmeier
Copy link
Member

Feichtmeier commented Mar 6, 2021

Hi @Muqtxdir
I feel a bit ashamed for the work I made you here but what do you think about closing this and the launchpad issue, wait for hirsute to land and then try to get not only yaru into focal but the whole gtk 3.38 stack? I think this would be much easier and also safer and less work for everyone

@Muqtxdir
Copy link
Member Author

Muqtxdir commented Mar 6, 2021

No problem @Feichtmeier 👍 , I was also thinking about closing and then redoing when hirsute lands.

Closing this pull then

@Muqtxdir Muqtxdir closed this Mar 6, 2021
Yaru automation moved this from In progress to Done Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Yaru
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants