Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login /lock screen #661

Merged
merged 8 commits into from Jul 30, 2018
Merged

Login /lock screen #661

merged 8 commits into from Jul 30, 2018

Conversation

Feichtmeier
Copy link
Member

@Feichtmeier Feichtmeier commented Jul 27, 2018

image

  background-gradient-direction: vertical;
  background-gradient-start: #6D2169;
  background-gradient-end: #370026;

Back to a purple gradient as most people seem to dislike the white box (I like it :D)

This time we use a (undocumented) gradient without a SVG needed. Sadly this gradient is limited to either horizontal or vertical. @madsrh @Luxamman maybe you can chose colors and one of two directions :)

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@eaglersdeveloper
Copy link
Contributor

I see no point in using the dialog. It is using to distinguish content from the background for better understanding. I already talked about this in 662nd issue.

But here is the simple purple background.

@Feichtmeier
Copy link
Member Author

Ok great I understood your point already in the issue.

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

use fixed color for cancenl button because base_hover/active color does not work
@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Luxamman
Copy link

Luxamman commented Jul 29, 2018

Well, the colors are quite good IMO, I just darkened the bright and brightened the dark color a little. Also, the proposed way looks more fitting to the rest of the theme - loosing the nerdy dark and bringing colors and be more inviting to the common user. Lets see what the new screen brings.

Dark: 370026
Bright: 6D2169

Like always something to test on multi-systems.

For now the avatar icon is still dark if the user did not choose a pic.

Danke @Feichtmeier

Colors as proposed by luxamman in PR661
The buttons were strangely decorared (prbly by me)
@Feichtmeier
Copy link
Member Author

@Luxamman thanks, yeah now the gradient isn't so extreme anymore - good proposal. I updated the screenshot in the OP and pushed the colors + some improvements to the buttons and the entry

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@didrocks
Copy link
Member

A new test snap version is available using: snap refresh communitheme --channel=edge/yaru-pr661.
Further available updates will track that pull request then.

Switch back to stable or edge snap with snap refresh communitheme --stable or snap refresh communitheme --edge once you are done with it!
You may want to download as well gtk-common-themes snap from edge/yaru-pr661 channel to test your snaps with those changes.

Replace refresh with install if you haven't installed the snap yet.

@Paz-it
Copy link

Paz-it commented Jul 30, 2018

Great! 💜

The orange ring on the CANCEL is a bit off. is it intentional?

@clobrano
Copy link
Member

This looks nice, can we merge it for today's stable release or do you prefer review it some more?

@Feichtmeier Feichtmeier merged commit 8256d57 into master Jul 30, 2018
@Feichtmeier Feichtmeier deleted the login-/lock-screen branch July 30, 2018 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants