Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Add luminosity Color extension #12

Merged
merged 6 commits into from
Feb 3, 2023
Merged

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Jan 29, 2023

@jpnurmi I will need your help with the tests 😅

@Jupi007 Jupi007 requested a review from jpnurmi January 29, 2023 18:48
@jpnurmi
Copy link
Member

jpnurmi commented Jan 29, 2023

#13 should help :)

@Jupi007
Copy link
Member Author

Jupi007 commented Jan 29, 2023

@jpnurmi Thanks a lot, it works 🥳

@Jupi007 Jupi007 requested a review from jpnurmi February 3, 2023 20:21
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides the wrong ranges in the docs 👍

packages/yaru_colors/lib/src/yaru_color_extension.dart Outdated Show resolved Hide resolved
packages/yaru_colors/lib/src/yaru_color_extension.dart Outdated Show resolved Hide resolved
@Jupi007
Copy link
Member Author

Jupi007 commented Feb 3, 2023

Looks good besides the wrong ranges in the docs 👍

🙈 you're right.

@Jupi007
Copy link
Member Author

Jupi007 commented Feb 3, 2023

Fixed :)

Can I merge ?

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Jupi007 Jupi007 merged commit d684f66 into ubuntu:main Feb 3, 2023
@Jupi007 Jupi007 deleted the luminosity-ext branch February 3, 2023 21:57
@jpnurmi
Copy link
Member

jpnurmi commented Feb 7, 2023

Did we forget to release? I added you if you want to do the honors :)

@Jupi007
Copy link
Member Author

Jupi007 commented Feb 7, 2023

Oh, indeed. I have completely forgotten the release.
I'll do it at once :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants