Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing comments in YaruNavigationRailItem #418

Merged
merged 5 commits into from
Nov 25, 2022

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Nov 25, 2022

Imported from #399

Pull request checklist

  • This PR does not introduce visual changes

@Jupi007 Jupi007 requested a review from jpnurmi November 25, 2022 10:58
lib/src/layouts/yaru_navigation_rail_item.dart Outdated Show resolved Hide resolved
lib/src/layouts/yaru_navigation_rail_item.dart Outdated Show resolved Hide resolved
lib/src/layouts/yaru_navigation_rail_item.dart Outdated Show resolved Hide resolved
lib/src/layouts/yaru_navigation_rail_item.dart Outdated Show resolved Hide resolved
Jupi007 and others added 4 commits November 25, 2022 12:16
Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
Co-authored-by: J-P Nurmi <jp.nurmi@canonical.com>
@Jupi007
Copy link
Member Author

Jupi007 commented Nov 25, 2022

Thanks for the typography review @jpnurmi 👍

Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM even though I wouldn't trust my English proof-reading for anything more official 🤣

@Jupi007 Jupi007 merged commit ac7bb44 into main Nov 25, 2022
@Jupi007 Jupi007 deleted the YaruNavigationRail-comments branch November 25, 2022 11:28
@jpnurmi jpnurmi mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants