Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kCheckboxRadio* constants out of the public API #495

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Move kCheckboxRadio* constants out of the public API #495

merged 1 commit into from
Jan 11, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jan 11, 2023

@Jupi007 What about this? I left it to a separate PR because this could be controversial...

Ref: #489

Copy link
Member

@Jupi007 Jupi007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for asking, imo it is fine to move them like you did.
Those two bicephal public const has always been annoying me a bit :D

@jpnurmi
Copy link
Member Author

jpnurmi commented Jan 11, 2023

Phew, glad to hear that so we can get rid of them in auto-completion and docs :)
https://pub.dev/documentation/yaru_widgets/2.0.0-beta-3/yaru_widgets/yaru_widgets-library.html#constants

For a while, I did consider introducing a separate file for these but meh... maybe we can make these themable later, though.

@jpnurmi jpnurmi merged commit 5a341b4 into ubuntu:main Jan 11, 2023
@jpnurmi jpnurmi deleted the checkbox-radio-constants branch January 11, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants