Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and document constants #489

Closed
jpnurmi opened this issue Jan 11, 2023 · 0 comments · Fixed by #496
Closed

Clean up and document constants #489

jpnurmi opened this issue Jan 11, 2023 · 0 comments · Fixed by #496

Comments

@jpnurmi
Copy link
Member

jpnurmi commented Jan 11, 2023

  • prefix all public global constants (e.g. kYaruFoo)
  • avoid abbreviations (e.g Bg)
  • document all public constants
  • hide (togglable) constants that are shared for internal implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant