Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update goldens with new dependencies #630

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Update goldens with new dependencies #630

merged 1 commit into from
Feb 24, 2023

Conversation

Jupi007
Copy link
Member

@Jupi007 Jupi007 commented Feb 24, 2023

The yaru.dart changed its style in a patch version, so golden was invalid.

Pull request checklist

  • This PR does not introduce visual changes

@Jupi007 Jupi007 requested a review from jpnurmi February 24, 2023 09:55
@Jupi007 Jupi007 mentioned this pull request Feb 24, 2023
Merged
1 task
jpnurmi
jpnurmi approved these changes Feb 24, 2023
View reviewed changes
Copy link
Member

@jpnurmi jpnurmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the images! LGTM 👍

@Jupi007 Jupi007 merged commit 16a2f68 into ubuntu:main Feb 24, 2023
@Jupi007 Jupi007 deleted the update-goldens branch February 24, 2023 10:01
@jpnurmi jpnurmi mentioned this pull request Mar 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpnurmi jpnurmi jpnurmi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jupi007 @jpnurmi