feat: expose NavigationPage navigator observers #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhhhh this sounds nice. Does this also help with preservation of the state of a page if the app is rebuilt via layout/orientation builders? |
jpnurmi
changed the title
|
Do you mean this? That should be fixable now that the attached example works fine with the latest stable Flutter but this PR is about something else i.e. being able to observe from the outside of NavigationPage what happens in its internal Navigator. |
|
Okay that's also nice ok 👍 |
jpnurmi
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues where #730 and #731 left off. Exposing
Navigator.observersallows updating the GUI state when a (search or detail) page is popped off, for example.