Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(master-detail): expose Navigator properties #735

Merged
merged 1 commit into from Jul 24, 2023
Merged

feat(master-detail): expose Navigator properties #735

merged 1 commit into from Jul 24, 2023

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Jul 24, 2023 •
edited

@jpnurmi jpnurmi marked this pull request as draft July 24, 2023 14:40
@jpnurmi
feat(master-detail): expose Navigator properties
0e2b3da 
To bring YaruMasterDetailPage on par with YaruNavigationPage.
@jpnurmi jpnurmi marked this pull request as ready for review July 24, 2023 15:16
Feichtmeier
Feichtmeier approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@Feichtmeier Feichtmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks! lgtm

@jpnurmi jpnurmi merged commit f30b8d5 into ubuntu:main Jul 24, 2023
8 checks passed
@jpnurmi jpnurmi deleted the master-detail branch July 24, 2023 15:50
@github-actions github-actions bot mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Feichtmeier Feichtmeier Feichtmeier approved these changes

@d-loose d-loose Awaiting requested review from d-loose

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpnurmi @Feichtmeier