Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full prototype, including menu and shelf view. #10

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

i-ron-y
Copy link
Contributor

@i-ron-y i-ron-y commented May 30, 2018

As this is for the mobile site, I've only tested it in mobile-device mode. Not sure if they look okay in regular computer browsers but will that be something we'd need to take into account at all?

There's currently a bug whereby if you open up a full article and scroll down on that article, and then click a new article, the new article is scrolled down too. I'm looking into how to have the Article component (or the article content div?) automatically scroll back up to the top upon re-render. (FIXED)

@i-ron-y i-ron-y requested a review from psiemens May 30, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant