Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Guide 2020 template #1456

Closed
SamuelmdLow opened this issue May 13, 2024 · 1 comment
Closed

Fix Guide 2020 template #1456

SamuelmdLow opened this issue May 13, 2024 · 1 comment
Assignees

Comments

@SamuelmdLow
Copy link
Member

Example: https://ubyssey.ca/guide/2020/academics/the-basics/

Its broken, would be nice if it wasn't broken!

@brittkhat brittkhat self-assigned this May 14, 2024
@SamuelmdLow
Copy link
Member Author

This template does not work because it tries to use the reverse url function to get to the landing pages. But wagtail does not automatically set url pattern names for the page. To fix this we can hardcode the urls in ubyssey.ca/ubyssey/templates/guide/2020/header.html

There are some styling changes to make as well such as the images being commented out in ubyssey.ca/article/templates/article/objects/guide/article-box2022.html. The images are supposed to be used in guide 2020 but aren't in guide 2022 which also uses this block. We can get both to work as intended by making style="background-image: url('{{ image }}');" conditional to image being in the context ({% if image %}, and then going to ubyssey.ca/article/templates/article/article_page_guide_2022.html and remove image=prev_image.url and image=next_image.url from the context

The social media link styling is also off. You can look at ubyssey.ca/article/templates/article/objects/share_bar.html to see working link styling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants