Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRS /access does not return correct response #272

Open
ianfore opened this issue May 8, 2020 · 0 comments
Open

DRS /access does not return correct response #272

ianfore opened this issue May 8, 2020 · 0 comments
Assignees

Comments

@ianfore
Copy link

ianfore commented May 8, 2020

The following DRS call returns two access methods for the specified file
https://dataguids.org/ga4gh/drs/v1/objects/3ed3640c-8a82-4ec0-9d3e-2cd9b5a62707
See attached file for response
3ed3640c-8a82-4ec0-9d3e-2cd9b5a62707.txt

Given that response it should be possible to obtain a URL for the file via either of the following calls
https://dataguids.org/ga4gh/drs/v1/objects/3ed3640c-8a82-4ec0-9d3e-2cd9b5a62707/access/s3
https://dataguids.org/ga4gh/drs/v1/objects/3ed3640c-8a82-4ec0-9d3e-2cd9b5a62707/access/gs

Both return
{
"error": "no record found"
}

No authorization information was provided in the request - so it is certainly correct that the file is not returned. However, the appropriate DRS response in that case would likely be
403 | The requester is not authorized to perform this action.

It's not possible to tell whether the "no record found" error is masking the real issue (authorization) or whether the object is genuinely not found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants