Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix download link #720

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Fix download link #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04de447
Update notebook.py
chrispyles Aug 24, 2023
7244c66
Update CHANGELOG.md
chrispyles Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

**v5.1.3 (unreleased):**

* Fixed bug in submission zip download link per [#719](https://github.com/ucbds-infra/otter-grader/issues/719)

**v5.1.2:**

* Enabled the use of custom Jupyter kernels by enforcing the use of the `python3` kernel inside Otter grading containers per [#706](https://github.com/ucbds-infra/otter-grader/issues/706)
Expand Down
2 changes: 1 addition & 1 deletion otter/check/notebook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def continue_export():
out_html = f"""
<p>
Your submission has been exported. Click
<a href="{zip_path}" downloadzip_path target="_blank">here</a> to download
<a href="{zip_path}" download="{zip_path}" target="_blank">here</a> to download
the zip file.
</p>
"""
Expand Down
Loading