Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove nbconvert < 6 compat patches #785

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

chrispyles
Copy link
Member

Closes #777

@chrispyles chrispyles added the tech debt Refactors to eliminate tech debt label Mar 8, 2024
@chrispyles chrispyles added this to the v6.0.0 milestone Mar 8, 2024
@chrispyles chrispyles added this to In Progress in Otter-Grader Issues and Tasks via automation Mar 8, 2024
@chrispyles chrispyles marked this pull request as ready for review March 8, 2024 03:44
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 82.29%. Comparing base (afa146d) to head (8dbf900).

Files Patch % Lines
otter/export/exporters/via_html.py 20.00% 4 Missing ⚠️
otter/export/exporters/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             beta     #785      +/-   ##
==========================================
+ Coverage   82.21%   82.29%   +0.07%     
==========================================
  Files          64       64              
  Lines        4398     4389       -9     
==========================================
- Hits         3616     3612       -4     
+ Misses        782      777       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrispyles chrispyles merged commit 122a6f6 into ucbds-infra:beta Mar 8, 2024
3 checks passed
Otter-Grader Issues and Tasks automation moved this from In Progress to Done Mar 8, 2024
@chrispyles chrispyles deleted the remove-nbconvert-5 branch March 8, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Refactors to eliminate tech debt
Development

Successfully merging this pull request may close these issues.

None yet

1 participant