SISRP-6547 - Campus Solutions splash page #1
Conversation
| insert_final_newline = true | ||
| indent_style = space | ||
| indent_size = 2 | ||
| trim_trailing_whitespace = true |
There was a problem hiding this comment.
@winstonkim can we add an end of line here?
|
@winstonkim could you ping when when you've made the update? |
|
@ChristianV made the update! even cleaned the svg up, but travis doesnt seem to be running? |
| </div> | ||
| <div class="section section-1"> | ||
| <div class="container"> | ||
| <div class="square-container"> |
There was a problem hiding this comment.
@winstonkim indentation still looks a bit off, can you make sure we use the 2 spaces everywhere?
|
@winstonkim one last comment and interesting thing about travis, can't seem to make it work even though it's enabled. |
|
@winstonkim travis fix should have been applied in #6 - Can you rebase (we now have a merge conflict) and leave your |
|
@winstonkim looks like Can you have another look? |
winstonkim
force-pushed
the
gh-pages
branch
5 times, most recently
from
8cca2cc
to
04907ac
Compare
winstonkim
force-pushed
the
gh-pages
branch
from
04907ac
to
5c41497
Compare
|
@ChristianV got it to pass! |
| gulp.task('default', ['sass', 'watch', 'inlinesource']); | ||
|
|
||
| // Test Task | ||
| gulp.task('test', ['sass', 'watch', 'inlinesource', 'exit']); |
There was a problem hiding this comment.
@winstonkim could you remove the watch from this task? Also, aren't those tasks run asynchronously?
There was a problem hiding this comment.
@ChristianV made the changes, let me know if there are any other problems!
SISRP-6547 - Campus Solutions splash page
https://jira.berkeley.edu/browse/SISRP-6547