Fix a bug around internal node search (#738)

ucbrise · Jul 3, 2019 · 034ba6d · 034ba6d
1 parent df96eb4
commit 034ba6d
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/clipper_admin/clipper_admin/kubernetes/kubernetes_container_manager.py b/clipper_admin/clipper_admin/kubernetes/kubernetes_container_manager.py
@@ -424,9 +424,10 @@ def connect(self):
             if len(external_node_hosts) == 0 and self.useInternalIP:
                 msg = "No external node addresses found. Using Internal IP address"
                 self.logger.warning(msg)
-                for addr in node.status.addresses:
-                    if addr.type == "InternalIP":
-                        external_node_hosts.append(addr.address)
+                for node in nodes.items:
+                    for addr in node.status.addresses:
+                        if addr.type == "InternalIP":
+                            external_node_hosts.append(addr.address)
 
             if len(external_node_hosts) == 0:
                 msg = "Error connecting to Kubernetes cluster. No external node addresses found. You may pass in KubernetesContainerManager(useInternalIP=True) to connect to local Kubernetes cluster"