Update Ray's exercise10.ipynb: clarifications, fixes, typos. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,15 +138,20 @@ | |||
| " \"\"\"Set the neural net weights.\n", | |||
| " \n", | |||
| " This method should assign the given weights to the neural net.\n", | |||
| " \n", | |||
| " Args:\n", | |||
| " weights: a dict of `numpy.ndarray` objects (or a list of `num`.\n", | |||
There was a problem hiding this comment.
Should be either a dictionary of numpy arrays or a single numpy array.
| " This method should return the current neural net weights.\n", | ||
| " \n", | ||
| " Returns:\n", | ||
| " A dict mapping strings (variables' names) to `numpy.ndarray` objects.\n", |
There was a problem hiding this comment.
Should be either a dictionary of numpy arrays or a single numpy array.
| @@ -45,6 +45,7 @@ | |||
| "# Here 'weights' is a dictionary mapping variable names to the associated\n", | |||
| "# weights as a numpy array.\n", | |||
| "weights = variables.get_weights()\n", | |||
| "# ...Perhaps some updates on `weights`...\n", | |||
There was a problem hiding this comment.
Let's use 'weights' for consistency with line 45
| @@ -54,10 +55,11 @@ | |||
| "# Here 'weights' is a numpy array of all of the neural net weights\n", | |||
| "# concatenated together.\n", | |||
| "weights = variables.get_flat()\n", | |||
| "# ...Perhaps some updates on `weights`...\n", | |||
There was a problem hiding this comment.
Let's use 'weights' for consistency with line 55
|
All done. The incomplete docstrings were not intentional :-p |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jey @robertnishihara feel free to push back on this if you don't agree with the updated wordings.