New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend binary cards to work with up to 24 bits #407

Closed
timbellnz opened this Issue Feb 22, 2017 · 0 comments

Comments

2 participants
@timbellnz
Member

timbellnz commented Feb 22, 2017

Description

The cards activity was intended for up to about 8 bits, but it works nicely for 16:
http://csfieldguide.org.nz/en/interactives/binary-cards/index.html?digits=16

However, that makes you want 24 bits, and this seems to hang (on Chrome Version 56.0.2924.87 (64-bit) mac):
http://csfieldguide.org.nz/en/interactives/binary-cards/index.html?digits=24

It would be great if it could extend up to 24 bits or more (the images could just be grey??!), but if it's too difficult (e.g. the numbers will get very big), at least we could put in a check that the number of bits requested is within a feasible range.

Checklist

  • [x ] I have linked any relevant existing issues/suggestions in the description above (include #??? in your description to reference an issue, where ??? is the issue number)
  • [x ] I have applied relevant labels

If this is a code related issue, please include the following in your description:

  • [x ] Steps to reproduce the behavior
  • [x ] Which platform(s) and browser are you encountering the issue on
  • [x ] The behavior you expect to see, and the actual behavior

@JackMorganNZ JackMorganNZ modified the milestone: v2.10.0 - 'Kea' Aug 30, 2017

JackMorganNZ added a commit that referenced this issue Sep 1, 2017

Don't render dots for binary cards with more than 5000 dots (#407)
A gradient is displayed instead of individual dots.

JackMorganNZ added a commit that referenced this issue Sep 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment