Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python programs for sorting and searching sections #1279

Merged
merged 16 commits into from Jun 29, 2020
Merged

Update python programs for sorting and searching sections #1279

merged 16 commits into from Jun 29, 2020

Conversation

courtneycb
Copy link
Contributor

@courtneycb courtneycb commented Jun 14, 2020 •
edited

Changes

  • Replace download links for python files with links to the programs on repl.it.
  • Update python programs to be in line with PEP8 style guidelines.
  • Update binary search algorithm to correctly count comparisons and remove use of list slicing as it is inefficient.

TODO:

  • Consult with Tim about design decisions

Links for programs:
https://repl.it/@uccser/linear-binary-search-python3
https://repl.it/@uccser/linear-binary-search-python

https://repl.it/@uccser/selection-quicksort-python3
https://repl.it/@uccser/selection-quicksort-python

@courtneycb courtneycb self-assigned this Jun 14, 2020
@courtneycb courtneycb marked this pull request as ready for review June 29, 2020 00:36
eAlasdair
eAlasdair suggested changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@eAlasdair eAlasdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, normally I don't worry this much about style rules but if we advertise pep8 compliance we should make sure it absolutely is

csfieldguide/static/files/selection-quicksort-python3.py Outdated Show resolved Hide resolved
csfieldguide/static/files/linear-binary-search-python3.py Outdated Show resolved Hide resolved
csfieldguide/static/files/selection-quicksort-python2.py Outdated Show resolved Hide resolved
csfieldguide/static/files/selection-quicksort-python3.py Show resolved Hide resolved
eAlasdair
eAlasdair approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@eAlasdair eAlasdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:yay:

@courtneycb courtneycb merged commit f1444db into develop Jun 29, 2020
@courtneycb courtneycb deleted the update-python-programs branch June 29, 2020 06:24
@courtneycb courtneycb mentioned this pull request Jun 29, 2020
Merged
@uccser-bot uccser-bot mentioned this pull request Jul 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eAlasdair eAlasdair eAlasdair approved these changes

Assignees

@courtneycb courtneycb

Labels
content: chapters
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@courtneycb @eAlasdair