Upgrade to php 8.0.24 and fuelphp 1.9-develop #1407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP support for 7 is ending very soon, so this is and attempt to update to give the team some more runway. PHP 8.0.x doesn't have a very long life either, but this is better than nothing. Upgrading to PHP 8.0.x required upgrading fuel to a development version unfortunately - there's no official full release that has the updates required to work with PHP 8.0.x
Merged
|
The changes look good, just need you to update the target branch to |
|
@clpetersonucf I re-targeted the desired branch and have a pull request open over at ucfcdl/fuelphp-phpcs#1 to fix the code sniffer so our ci_tests will pass on Materia. It'll require a few steps back and forth to get it working. (first the pr gets merged, then tagged, then the composer.json and .lock file need updates here in Materia) |
|
|
clpetersonucf
added
the
Awaiting Additional Updates
clpetersonucf
added
hacktoberfest-accepted
and removed
Awaiting Additional Updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP support for 7 is ending very soon, so this is an attempt to update to give the team some more runway. PHP 8.0.x doesn't have a very long life either, but this is better than nothing.
Upgrading to PHP 8.0.x required upgrading fuel to a development version unfortunately - there's no official non-dev release that has the updates required to work with PHP 8.0.x