Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents play score percentages over 100 #1584

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Prevents play score percentages over 100 #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b80f9e
Adds check to session_play set_complete to ensure percent is never al…
clpetersonucf May 8, 2024
b4819e9
Adds >100% edge case detection to score distribution API response to …
clpetersonucf May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fuel/app/classes/materia/score/manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,9 @@ static public function get_widget_score_distribution($inst_id)
$semesters = [];
foreach ($result as $log)
{
// remove any erroneous > 100% scores from the distribution graph
if ($log['bracket'] > 9) continue;

$key = $log['id'];
if ( ! isset($semesters[$key]))
{
Expand Down
3 changes: 3 additions & 0 deletions fuel/app/classes/materia/session/play.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,9 @@ public function get_by_id($play_id=0)

public function set_complete($score, $possible, $percent)
{
// ensure percent is never inadvertently set to a value over 100, which will break things
if ($percent > 100) $percent = 100;

// set max score to the current score
$max_percent = $percent;

Expand Down
Loading