Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches storage driver to s3. This uses fakes3 on dev and AWS S3 bucket on prod. (Tested with personal S3 bucket. Not tested on materia server yet)
Things to note:
$_ENV
vars inbootstrap.php
during local development, and production also doesn't appear to need them. If this is a mistake, lmkrun_first.sh
)run_tests.sh
, essentially deleting all uploaded assets. My initial fix for this is just create a whole new fakes3 container for testing, and drop it after tests are complete.How to test:
run_first.sh
should run without errors, meaning all widget assets were uploaded. Checks3mnt/
folder in local fakes3 containerrun_tests.sh
remove any assets? (Do assets in widget demos still load?)If you want to test your own S3 bucket, you'll need to set these variables in your
.env.local
file in the root folder. Here's the guide I used for setting up AWS locallyTo Do:
lock_for_processing
andunlock_for_processing
for when assets are resized