Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique IDs in Tests #399

Open
Thetwam opened this issue Jul 14, 2020 · 0 comments
Open

Unique IDs in Tests #399

Thetwam opened this issue Jul 14, 2020 · 0 comments
Assignees

Comments

@Thetwam
Copy link
Member

Thetwam commented Jul 14, 2020

We recently received a PR (#398) where we were setting a quiz group's course ID to self.id rather than self.course_id. This should have been caught by our tests, but wasn't since we set the id of most of our test objects to 1. It's entirely possible there are other similar issues hidden because we reuse ID numbers so frequently.

Convert our tests to use unique ID numbers between object types. (e.g. 5 for courses, 27 for quizzes, etc.)

This will likely be a fair bit of work, since we reuse the fixtures in many places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants