Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #45 docker #46

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Issue #45 docker #46

wants to merge 22 commits into from

Conversation

ssilverm
Copy link
Member

@ssilverm ssilverm commented Sep 3, 2021

Proposed Changes

This Dockerizes Quiz Extensions.

Resolves #45

@Thetwam Thetwam changed the title Issue/45 docker Issue #45 docker Oct 15, 2021
Copy link
Member

@Thetwam Thetwam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add FLASK_APP and FLASK_DEBUG environment variables

Tests fail because the template for config.py is missing. Need to update run-tests.yml to support the new setup.

I noticed HTTPS isn't supported. I would like to retain that functionality.

README.md Outdated Show resolved Hide resolved
docker-compose.production.yaml Outdated Show resolved Hide resolved
devops/nginx.conf Outdated Show resolved Hide resolved
config.py Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Thetwam
Copy link
Member

Thetwam commented Oct 19, 2021

Also, status page is now failing to load index and xml pages:

Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/urllib3/connection.py", line 175, in _new_conn
    (self._dns_host, self.port), self.timeout, **extra_kw
  File "/usr/local/lib/python3.7/site-packages/urllib3/util/connection.py", line 96, in create_connection
    raise err
  File "/usr/local/lib/python3.7/site-packages/urllib3/util/connection.py", line 86, in create_connection
    sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

@Thetwam
Copy link
Member

Thetwam commented Nov 2, 2021

Need to pull in latest develop, address conflicts, and address comments above.

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.65%. Comparing base (90656e8) to head (267e326).

❗ Current head 267e326 differs from pull request most recent head e2e637a. Consider uploading reports for the commit e2e637a to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #46   +/-   ##
========================================
  Coverage    98.64%   98.65%           
========================================
  Files            4        5    +1     
  Lines         1111     1114    +3     
========================================
+ Hits          1096     1099    +3     
  Misses          15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ssilverm ssilverm requested a review from Thetwam November 4, 2021 16:32
- remove script_name from nginx.conf to fix index route
- map ports 80:80 and 443:443 in docker-compose.yml
- pin SQLAlchemy and Werkzeug versions
- use 'docker compose' commands instead of 'docker-compose'
- linting fixes
- gitignore docker's copy of ngingx.conf and uwsgi.ini
- remove Python 3.7 from runner matrix
- use Python 3.8 in Docker image
- add newline to CONTRIBUTING.md
- ignore markdown-style.rb rule for 'ul-indent'
- use a single temporary Docker container for tests and tear down when complete
- update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants