-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholders #30
Placeholders #30
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
OK. Looking at that notebook in Chapter 11 – did you want to change something about it? (I'm guessing that it's not involved in this placeholder work; and, its changes just appear to be in the metadata from Jupyter.) |
Yes, exactly. I don't want to change anything
…---
Amanda Kube, MS, PhD
Preceptor in Data Science
Data Science Institute
The University of Chicago
5801 S Ellis Ave
Chicago, IL 60637
***@***.***
________________________________
From: Jesse London ***@***.***>
Sent: Tuesday, November 15, 2022 4:48:26 PM
To: chicago-cdac/textbook-datascience-1 ***@***.***>
Cc: Amanda Kube ***@***.***>; Author ***@***.***>
Subject: Re: [chicago-cdac/textbook-datascience-1] Placeholders (PR #30)
OK. Looking at that notebook in Chapter 11 – did you want to change something about it? (I'm guessing that it's not involved in this placeholder work; and, its changes just appear to be in the metadata from Jupyter.)
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/chicago-cdac/textbook-datascience-1/pull/30*issuecomment-1315969992__;Iw!!BpyFHLRN4TMTrA!4o9saoHP7EFSdM79vfKkduak3Udh_SAoo6byBDahCIAZzbyLmfj-yC0FHQpG8R-lHdsf90volfHl_3pUefCeGUgNRw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AECO4RCAM5VSRQRRI5KY5XLWIQHLVANCNFSM6AAAAAASBEBHTY__;!!BpyFHLRN4TMTrA!4o9saoHP7EFSdM79vfKkduak3Udh_SAoo6byBDahCIAZzbyLmfj-yC0FHQpG8R-lHdsf90volfHl_3pUefDtlXjIDw$>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
OK sure. I can just revert that one file then and it's all good. FYI: It looks like perhaps the issue is that your fork's main ("master") branch is far out of sync with this repo's. Otherwise this all seems great – you're using branches on your fork, etc. I believe if you fix up your fork's For example in your fork's checkout:
As a result, whereas your fork now says that it's ahead and/or behind this repository's And I hope that helps! |
(also: reverted accidental changes)
OK! That took some doing but I believe it's all good now. The end result is of course that this won't change anything in chapter 11 (and won't bring in 40 or so unrelated changesets). I'll merge it in but if you can please take a look to confirm it looks correct to you. (And if you're able to clean up your fork that might help a great deal.) Thanks! |
Dan wants placeholders in first two chapters. Also, noticing that there are differences between these two in one of the notebooks in chapter 11. Wasn't able to resolve, hoping you can