Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholders #30

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Placeholders #30

merged 1 commit into from
Nov 16, 2022

Conversation

amandakube
Copy link
Collaborator

Dan wants placeholders in first two chapters. Also, noticing that there are differences between these two in one of the notebooks in chapter 11. Wasn't able to resolve, hoping you can

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jesteria
Copy link
Member

OK. Looking at that notebook in Chapter 11 – did you want to change something about it? (I'm guessing that it's not involved in this placeholder work; and, its changes just appear to be in the metadata from Jupyter.)

@amandakube
Copy link
Collaborator Author

amandakube commented Nov 15, 2022 via email

@jesteria
Copy link
Member

OK sure. I can just revert that one file then and it's all good.


FYI: It looks like perhaps the issue is that your fork's main ("master") branch is far out of sync with this repo's. Otherwise this all seems great – you're using branches on your fork, etc. I believe if you fix up your fork's master branch this will go smoother.

For example in your fork's checkout:

  • If you don't have this repository configured:

    git remote add upstream git@github.com:chicago-cdac/textbook-datascience-1.git

    (…And I'll refer to it as upstream regardless.)

  • Fetch this repository's changesets:

    git fetch upstream
  • Reset your fork's master branch to match that of this repository – (discarding anything in that branch of your fork that's not in this repository!)

    git checkout master
    git reset --hard upstream/master  
    git push --force origin master

As a result, whereas your fork now says that it's ahead and/or behind this repository's master branch, it should then say that it's up-to-date.

image

And I hope that helps!

@jesteria jesteria added the content textbook content label Nov 16, 2022
@jesteria
Copy link
Member

OK! That took some doing but I believe it's all good now. The end result is of course that this won't change anything in chapter 11 (and won't bring in 40 or so unrelated changesets).

I'll merge it in but if you can please take a look to confirm it looks correct to you.

(And if you're able to clean up your fork that might help a great deal.)

Thanks!

@jesteria jesteria merged commit 9c28ecd into uchicago-dsi:master Nov 16, 2022
@jesteria jesteria mentioned this pull request Nov 29, 2022
SusannaLange pushed a commit to SusannaLange/textbook-datascience-1 that referenced this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content textbook content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants