Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter 15 - data ethics #38

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Conversation

campbelle1
Copy link
Collaborator

Please add chapter 15 on data ethics and let me know if any changes need to be made. Thank you.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@campbelle1 campbelle1 merged commit 256f761 into uchicago-dsi:master Dec 2, 2022
@jesteria jesteria added the content textbook content label Dec 2, 2022
@jesteria
Copy link
Member

jesteria commented Dec 2, 2022

Outside of trying to build the textbook with these changes, they look good to me. Thanks. (I think I see something to which the builder might raise an objection, but nothing too serious. And perhaps you tried building the textbook yourself.)

…To be sure, did you mean to merge the PR?

@@ -0,0 +1,62 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: Indeed, it's not a big deal, but the use of "non-consecutive headers" upsets textbook generation. For example:

# Pillar 1
### The attainment, usage, storage, analysis, and maintenance…

These headers are used for declaring sections within each document, after all. Perhaps it would make sense to merely set that line to be bold:

**The attainment, usage, storage, analysis, and maintenance…**

…And the same with others in this chapter:

textbook/15/2/pillar1.ipynb:10003: WARNING: Non-consecutive header level increase; 1 to 3 [myst.header]
textbook/15/3/pillar2.ipynb:10003: WARNING: Non-consecutive header level increase; 1 to 3 [myst.header]
textbook/15/4/pillar3.ipynb:10003: WARNING: Non-consecutive header level increase; 1 to 3 [myst.header]
textbook/15/5/pillar4.ipynb:10003: WARNING: Non-consecutive header level increase; 1 to 3 [myst.header]

Reply via ReviewNB

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to be sure, this is how it looks in the textbook:

image

@jesteria
Copy link
Member

jesteria commented Dec 8, 2022

…All right, in order to make the textbook happy, I corrected the above syntax (7605386).

campbelle1 pushed a commit to campbelle1/EC_textbook-datascience-1 that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content textbook content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants