Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatting Control Statement Chapter #39

Merged
merged 3 commits into from
Dec 8, 2022

Conversation

SusannaLange
Copy link
Collaborator

@SusannaLange SusannaLange commented Dec 5, 2022

Reformatted this chapter to be earlier: no data visualization tools used, more intro to boolean arrays, deleted sampling from a DataFrame (moved to Empirical prob chapter). This chapter is titled: Randomness and Control Statements

Edited group, merge, pivot chapter to be three sections instead of two.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@SusannaLange SusannaLange changed the title Second branch Reformatting Control Statement Chapter Dec 5, 2022
@jesteria jesteria added the content textbook content label Dec 6, 2022
@jesteria
Copy link
Member

jesteria commented Dec 6, 2022

FYI: The textbook's table of contents in textbook/_toc.yml has to be updated to reflect the file name changes and additions here. These are the warnings I received when building the textbook locally:

textbook-datascience-1$ manage build --all

…

textbook/intro.md:: WARNING: toctree contains reference to nonexisting document '05/placeholder5' [etoc.ref]
textbook/05/1/Intro.ipynb: WARNING: document isn't included in any toctree
textbook/05/2/Control_Statements_conditionals.ipynb: WARNING: document isn't included in any toctree
textbook/05/3/Control_Statements_Iteration.ipynb: WARNING: document isn't included in any toctree
textbook/05/randomness-and-control-statement.md: WARNING: document isn't included in any toctree
textbook/07/1/Merge.ipynb: WARNING: document isn't included in any toctree
textbook/07/2/Groups.ipynb: WARNING: document isn't included in any toctree
textbook/07/3/pivots.ipynb: WARNING: document isn't included in any toctree
textbook/07/merge-group-pivot.md:: WARNING: toctree contains reference to nonexisting document '07/1/Merge_groups' [etoc.ref]
textbook/07/merge-group-pivot.md:: WARNING: toctree contains reference to nonexisting document '07/2/Groups_pivots' [etoc.ref]

@SusannaLange
Copy link
Collaborator Author

Thanks, I just updated the table of contents!

@jesteria
Copy link
Member

jesteria commented Dec 7, 2022

Cool. I'm still getting an error. (BTW you can probably build the textbook with your changes as well.)

$ manage build --all

textbook/07/merge-group-pivot.md:: WARNING: toctree contains reference to nonexisting document '07/2/pivots' [etoc.ref]
textbook/07/3/pivots.ipynb: WARNING: document isn't included in any toctree

I can just fix this up.

@jesteria
Copy link
Member

jesteria commented Dec 7, 2022

OK! I'm guessing that change will not offend.

Looks good to me. I can merge if it's ready to go.

@SusannaLange
Copy link
Collaborator Author

Thanks for fixing that for me! It's ready now.

Susanna Lange and others added 3 commits December 8, 2022 11:23
@jesteria jesteria merged commit e26b46f into uchicago-dsi:master Dec 8, 2022
campbelle1 pushed a commit to campbelle1/EC_textbook-datascience-1 that referenced this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content textbook content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants