Avoid loading keywords from a protobuf.

uchicago-sg · Mar 7, 2016 · 5c37b95 · 5c37b95
1 parent f56f545
commit 5c37b95
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/caravel/model/full_text.py b/caravel/model/full_text.py
@@ -18,8 +18,17 @@ def grouper(iterable, n, fillvalue=None):
     return itertools.izip_longest(fillvalue=fillvalue, *args)
 
 
+class AvoidRereadingFromPBProperty(ndb.ComputedProperty):
+    """
+    Since ComputedPropertys are overwritten on writes anyway, we might as well
+    avoid the expensive desearlization process for reads.
+    """
+
+    def _deserialize(self, ent, property, depth=1): pass
+
+
 class FullTextMixin(ndb.Model):
-    keywords = ndb.ComputedProperty(
+    keywords = AvoidRereadingFromPBProperty(
         lambda self: list(set(self._keywords())), repeated=True)
 
     @classmethod