Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add App Engine users to authenticate to Marketplace #189

Merged
merged 1 commit into from
Dec 17, 2015

Conversation

fatlotus
Copy link
Member

The lazy person's path to Shibboleth logins. Right now there's no additional verification — but once we add moderation that can feed into the verification level of each email.

@fatlotus fatlotus force-pushed the shibboleth-logins branch 5 times, most recently from 84c0d44 to ad82677 Compare December 10, 2015 16:47
@georgeteo
Copy link
Contributor

Comments:

  1. Did you break title overflow on thumbnail view? (see: https://shibboleth-logins-dot-caravel-code-reviews.appspot.com/)
  2. Padding for the inquiry box.

screen shot 2015-12-14 at 3 13 11 pm

3. Maybe add a line telling Hospital staff to use email. 4. Sign in with CNET links to Google. People might use their regular Google account. (Cuz it isn't the standard shibboleth screen). Thoughts on how to fix this issue?

@fatlotus
Copy link
Member Author

Ah- (4) at least is an infrastructure problem. We can only force Google to use Shibboleth for UChicago.edu when we are on uchicago.edu, which caravel-code-reviews is not. (Try https://resurrection-dot-hosted-caravel.appspot.com for a demo.)

@georgeteo
Copy link
Contributor

Okay. (1), (2), and (3)?

@fatlotus fatlotus merged commit ba6c5c5 into master Dec 17, 2015
@fatlotus fatlotus deleted the shibboleth-logins branch December 17, 2015 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants