Add support for full-text search #192
Conversation
fatlotus
force-pushed
the
add-full-text-search
branch
from
03c0196
to
5d2c0ba
Compare
fatlotus
force-pushed
the
add-full-text-search
branch
from
5d2c0ba
to
e3a2ded
Compare
| memcache.set_multi(writeback, time=3600, key_prefix=FTS) | ||
|
|
||
| # Elide potentially stale entries from the cache. | ||
| for candidate in ndb.get_multi([key for key in keys if key in matches]): |
There was a problem hiding this comment.
Can you explain this bit?
It seems to me that keys will be the keys for the last word in words from the for loop in line 28.
Do you want to aggregate al keys from all the words first?
There was a problem hiding this comment.
We're doing something sorta tricky. (First, keys will never be null since words is non-empty.) Each keys is in order, so we iterate through one of them — but remove any that aren't in all matches (if key in matches). Hence we get a list of keys, in order, that contain each word.
I'll see if I can add a comment to that effect since it's certainly not explained well as-is.
There was a problem hiding this comment.
Why not just take matches then?
There was a problem hiding this comment.
Matches is a set so it might not be in order.
Add support for full-text search
Also fairly rudimentary. This brings us (almost) up to parity with the old site.