Temporarily hide emails #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -11,18 +11,16 @@ | |||
| <div class="col-xs-12"> | |||
| <form class="form" method="post" role="form" | |||
| enctype="multipart/form-data"> | |||
| <p>Alumni/BSD/Medicine/Medical School affiliates: if you are unable | |||
There was a problem hiding this comment.
Nooo. Why is this back at the top again?
There was a problem hiding this comment.
Oh! I thought that was Git being wonky. Will revert.
fatlotus
force-pushed
the
temporarily-hide-emails
branch
from
e8400f8
to
6b2fc5a
Compare
|
Reverted! |
|
Has merge conflicts? |
| listing might not be posted immediately. We reserve the right to | ||
| remove listings at any time. | ||
| </div> | ||
| <p>Alumni/BSD/Medicine/Medical School affiliates: if you are unable |
There was a problem hiding this comment.
Why is it a
tag instead of the
?
There was a problem hiding this comment.
Oh, good point. I think I must've been using an old master for this one...
fatlotus
force-pushed
the
temporarily-hide-emails
branch
2 times, most recently
from
a62aa5c
to
bfe63dc
Compare
| listing might not be posted immediately. We reserve the right to | ||
| remove listings at any time. | ||
| </div> | ||
| <p class="alert alert-warning" role="alert"> |
There was a problem hiding this comment.
Have not reverted to the correct master?
There was a problem hiding this comment.
I think it is. The <p> is more semantic than a <div>, but it should show up in the same manner.
There was a problem hiding this comment.
Oh oops. I missed the CSS class there. Sure.
fatlotus
force-pushed
the
temporarily-hide-emails
branch
from
bfe63dc
to
8542076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized on Wednesday that we never really talked about showing people's emails, so I un-showed them, pending further policy discussion.