Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The time_varying field output is two steps ahead of k-wave #34

Closed
astanziola opened this issue May 12, 2022 · 1 comment · Fixed by #33
Closed

The time_varying field output is two steps ahead of k-wave #34

astanziola opened this issue May 12, 2022 · 1 comment · Fixed by #33
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@astanziola
Copy link
Member

No description provided.

@astanziola astanziola added bug Something isn't working help wanted Extra attention is needed labels May 12, 2022
@btreeby
Copy link
Member

btreeby commented May 13, 2022

This is solved as part of #33, in particular bc4accf. Time varying sources now have the same time axis as k-Wave. However, the output for p0 sources is still offset by one time step, as k-Wave adds the p0 at the end of time loop, and j-Wave at the beginning. We are documenting, but not modifying, this behaviour for now. See #35.

@btreeby btreeby self-assigned this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants