jWave vs kWave unit tests #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #33 +/- ##
==========================================
+ Coverage 43.76% 47.75% +3.99%
==========================================
Files 15 15
Lines 866 936 +70
==========================================
+ Hits 379 447 +68
- Misses 487 489 +2
Continue to review full report at Codecov.
|
Matlab test update
|
Closes #28 |
astanziola
reviewed
May 14, 2022
jwave/acoustics/time_varying.py
Outdated
| @@ -215,53 +216,69 @@ def simulate_wave_propagation( | |||
| checkpoint: bool = False, | |||
| params = None, | |||
| smooth_initial = True, | |||
| return_params = False, | |||
There was a problem hiding this comment.
I'm removing this input, as the optional output of the parameters is already handled by jaxdf within an opeator decorator.
astanziola
approved these changes
May 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a systematic test of
time_varying.py, in particular thesimulate_wave_propagationsolver. A variety of simulations are setup:The tests are implemented in two files:
test_kwave_ivpfor initial value problems (p0 source)test_kwave_tvspfor time varying mass sources (p source)On a Linux or Mac system with MATLAB installed and accessible via the
matlabcommand, and k-Wave on the default path, the test scripts will also run the examples in k-Wave to generate the test data.As part of the development of the tests, and number of bug fixes where implemented (see also #36).
Closes #31
Closes #34