Skip to content
This repository has been archived by the owner on Nov 9, 2022. It is now read-only.

Error Text? #153

Closed
ebollens opened this issue Nov 20, 2012 · 4 comments
Closed

Error Text? #153

ebollens opened this issue Nov 20, 2012 · 4 comments
Assignees
@ebollens
Milestone
0.1.06

Comments

@ebollens
Copy link
Contributor

Right now, our color strategy (https://github.com/ucla/WebBlocks/wiki/Color-Strategy) seems to be missing one key feature: error. The problem, as I see it, is that we already have two moods that are similar: important and danger. However, error is a bit different in context than either of these two. Should we add another mood?

@loganfranken @atsengucla @ccheung
@alicetseng
Copy link
Contributor

hey @ebollens is danger a common use-case? I'd think error would be a decent replacement for danger. Maybe rather than adding a new one, just subbing?

@ebollens
Copy link
Contributor Author

@atsengucla the danger use case fits for things like a delete button.

@loganfranken
Copy link
Contributor

Using .error as a CSS class has been a very common pattern in my web development experience and I think .important and .danger stand on their own, so I would support adding it.

@ghost ghost assigned ebollens Dec 10, 2012
@ebollens
Copy link
Contributor Author

This has been moved to milestone 0.1.06, and I've assigned it to myself for implementation.

ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens
Add error mood to the color implementation [#153]
0a46c7c
ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens
Download compiled jQuery rather than compile it directly [#153]
457024b
ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens
Add demo for error mood [#153]
11a5e17
ebollens pushed a commit that referenced this issue Feb 22, 2013
Merge pull request #214 from ebollens/fix/153
1fc1409 
Add error mood to color implementation [fixes #153]
ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens @loganfranken
Add error mood to the color implementation [#153]
526e5b1
ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens @loganfranken
Download compiled jQuery rather than compile it directly [#153]
00d3ab2
ebollens added a commit that referenced this issue Feb 22, 2013
@ebollens @loganfranken
Add demo for error mood [#153]
800dc66
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ebollens ebollens

Labels
None yet
Projects
None yet
Milestone
0.1.06
Development

No branches or pull requests
3 participants
@ebollens @loganfranken @alicetseng