Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix util module structure #749

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Fix util module structure #749

merged 3 commits into from
Jun 8, 2023

Conversation

zhuchcn
Copy link
Member

@zhuchcn zhuchcn commented May 27, 2023

moPepGen/util/init.py was refactored to import all modules, so we can get access to all functions. We have some functions having the same name as the module (script) name, so the old way will override those modules making them not accessable.

Description

Closes #...

Checklist

  • This PR does NOT contain PHI or germline genetic data. A repo may need to be deleted if such data is uploaded. Disclosing PHI is a major problem.
  • This PR does NOT contain molecular files, compressed files, output files such as images (e.g. .png, .jpeg), .pdf, .RData, .xlsx, .doc, .ppt, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.
  • I have read the code review guidelines and the code review best practice on GitHub check-list.
  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
  • I have added the major changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.
  • All test cases passed locally.

…stead of functions, so we can then get access to all functions of all modules
@zhuchcn zhuchcn requested a review from lydiayliu May 27, 2023 15:15
@zhuchcn zhuchcn merged commit 255de61 into main Jun 8, 2023
2 checks passed
@zhuchcn zhuchcn deleted the czhu-fix-util branch June 8, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants