Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented classification #326

Closed
tiferrei opened this issue Feb 25, 2018 · 8 comments
Closed

Undocumented classification #326

tiferrei opened this issue Feb 25, 2018 · 8 comments

Comments

@tiferrei
Copy link
Contributor

tiferrei commented Feb 25, 2018

Hi there,
I've just noticed that there are some new(?) classifications that are not in the docs.
These are:

  • TH
  • CFE
  • MR
  • ER
  • CF

What do these stand for?

Thanks,
Tiago

@wilhelmklopp
Copy link
Contributor

Very good question

@tiferrei
Copy link
Contributor Author

tiferrei commented Mar 6, 2018

@ChristopherHammond13 any clue what these could mean? I'd be happy to make a PR for the docs if you just list the meanings here.

@ChristopherHammond13
Copy link
Contributor

Hey! Apologies for not getting back to this sooner. I have done some digging and will (hopefully soon!) be sent the data dictionary for the CMIS database that this talks to. With that I'll be able to fill in all the random bits of data we don't know.

Could you give me some example bookings that are coming up with these and I'll see what I can add from guess-work?

@tiferrei
Copy link
Contributor Author

Sure thing, here are some examples:

TH

{
      "roomname": "IOE - Bedford Way (20) - 744",
      "roomid": "744",
      "siteid": "162",
      "sitename": "IOE - Bedford Way, 20",
      "capacity": 25,
      "classification": "TH",
      "automated": "N",
      "location": {
        "address": [
          "20 Bedford Way",
          "London",
          "WC1H 0AL",
          ""
        ],
        "coordinates": {
          "lat": "51.523471",
          "lng": "-0.1285067"
        }
      }
    }

CFE

{
      "automated": "N",
      "location": {
        "address": [
          "9-11 Endsleigh Gardens",
          "London",
          "WC1H 0EH",
          ""
        ],
        "coordinates": {
          "lng": "-0.1314654",
          "lat": "51.526198"
        }
      },
      "capacity": 18,
      "roomid": "EGG5",
      "roomname": "IOE - Endsleigh Gardens (9-11) - G05",
      "siteid": "084",
      "sitename": "IOE - Endsleigh Gardens, 9-11",
      "classification": "CFE"
    }

MR

{
      "roomname": "Wilkins Garden Room",
      "roomid": "34",
      "siteid": "050",
      "sitename": "Bernard Katz Building",
      "capacity": 20,
      "classification": "MR",
      "automated": "P",
      "location": {
        "address": [
          "Gower Street,",
          "London",
          "WC1E 6BT",
          ""
        ],
        "coordinates": {
          "lat": "51.5247725",
          "lng": "-0.1334268"
        }
      }
    }

ER

{
      "roomname": "Wilkins Building (Main Building) North Observatory",
      "roomid": "XG1",
      "siteid": "005",
      "sitename": "Main Building",
      "capacity": 6,
      "classification": "ER",
      "automated": "N",
      "location": {
        "address": [
          "Gower Street",
          "London",
          "WC1E 6BT",
          ""
        ],
        "coordinates": {
          "lat": "51.524699",
          "lng": "-0.13366"
        }
      }
    }

CF

{
      "roomname": "Wilkins Building (Main Building) Whistler Room",
      "roomid": "G09D",
      "siteid": "005",
      "sitename": "Main Building",
      "capacity": 10,
      "classification": "CF",
      "automated": "N",
      "location": {
        "address": [
          "Gower Street",
          "London",
          "WC1E 6BT",
          ""
        ],
        "coordinates": {
          "lat": "51.524699",
          "lng": "-0.13366"
        }
      }
    }

@maisieccino
Copy link

MR - Marquee? is the only one I can get 🤔

@ChristopherHammond13
Copy link
Contributor

MR - Marquee makes sense.
ER - Equipment room
I think all the classifications are here: https://roombooking.ucl.ac.uk/rb/bookableSpace/viewAllBookableSpace.html?invoker=EFD

@ChristopherHammond13
Copy link
Contributor

Update: I'm currently updating the room bookings API to return a human-readable version of the room type (with the field classification_str) based on the data shown on the UCL Room Bookings site. Watch this space! :)

@ChristopherHammond13
Copy link
Contributor

This has now been merged to Staging. The documentation has not been built yet because we're in the process of fixing up some issues with our documentation build environment but hopefully this will be in prod by the end of the week. Apologies for the exam delays!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants