Fixes null values in export function. #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortongn
requested changes
May 8, 2024
There was a problem hiding this comment.
@scherztc This is great. Worked fine with my testing and the code is WAY better. One requested change: Join the multivalued fields with a ', ' (comma and a space) instead of just ','. It looks nicer in the spreadsheet if each value has a space after the comma.
hortongn
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
The reason the spreadsheets were blank is that we had nil values for
tech_leads, departments, developers, product_owners, admin_users
We refactored this code by DRYing it up and introduced ERROR Handling for nil fields.
We also added a test for nil values.