FEATURE MERGE - 407 add gems #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, you have this PR currently set to merge into qa instead of your SSO feature branch. |
|
Thanks Glen! We're planning to review PR's during our daily meetings. I HOPE that one of us would have caught this at that point, but we may easily have missed it. |
Janell-Huyck
force-pushed
the
407-feature-branch-add-sso
branch
from
1871fcd
to
8b80f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the gems we expect to need to use while making the change to SSO.
We do not expect to need 'omniauth-openid' because we are integrating directly with Shibboleth and validating against a set list of approved users. We do not allow any other time of login or account creation.