Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract code for UC's Central Login authentication into it's own gem #725

Open
hortongn opened this issue Apr 4, 2019 · 0 comments
Open
Labels
Priority: low #SCHOLAR type: refactor Code tasks that don't change behavior
Milestone

Comments

@hortongn
Copy link
Member

hortongn commented Apr 4, 2019

(moved from uclibs/scholar_uc_legacy#560)

Descriptive summary

We will likely eventually want to use the code for Shibboleth authentication in other apps. We should see if we can extract the bulk of the logic into a separate gem that will let us use it in other rails apps that use Devise.

Assumptions:

  • We may want to use this with non-Samvera apps
  • Much of what is in CallbacksController#shibboleth can be moved to a gem
  • Much of the changes we made to views in the app can be left in the app
  • The gem would have omniauth-shibboleth as a dependency
  • The gem would be specific to UC's authentication so it will grab the attributes that UC provides (first name, last name, department, etc.)
  • The gem will handle properly logging out of Shibboleth when logging out of the app.
  • Everything will be well tested.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: low #SCHOLAR type: refactor Code tasks that don't change behavior
Projects
None yet
Development

No branches or pull requests

1 participant