elf2flt: handle binutils >= 2.34 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapier
requested changes
Feb 13, 2020
configure.ac
Outdated
|
|
||
| AC_TRY_COMPILE([#include <bfd.h>], | ||
| [const asection *sec; bfd_section_size(sec);], | ||
| bfd_section_size_macro_has_one_arg=yes, |
There was a problem hiding this comment.
name this more generically like bfd_section_api_takes_bfd or something. they converted all the APIs at once, so there's no need to test each one individually.
elf2flt.c
Outdated
| @@ -149,6 +149,17 @@ const char *elf2flt_progname; | |||
| #define O_BINARY 0 | |||
| #endif | |||
|
|
|||
| #if defined(HAVE_BFD_SECTION_SIZE_MACRO_HAS_ONE_ARG) | |||
| #define elf2flt_bfd_section_size(abs_bfd, s) bfd_section_size(s) | |||
There was a problem hiding this comment.
the point of the API change is that the bfd isn't actually used by any of the bfd_section funcs. so we should structure our API similarly.
#define elf2flt_bfd_section_size(s) bfd_section_size(s)
#else
#define elf2flt_bfd_section_size(s) bfd_section_size(NULL, s)
elf2flt.c
Outdated
| @@ -149,6 +149,17 @@ const char *elf2flt_progname; | |||
| #define O_BINARY 0 | |||
| #endif | |||
|
|
|||
| #if defined(HAVE_BFD_SECTION_SIZE_MACRO_HAS_ONE_ARG) | |||
configure.ac
Outdated
| @@ -212,6 +212,31 @@ AC_CHECK_FUNCS([ \ | |||
| strsignal \ | |||
| ]) | |||
|
|
|||
| dnl Various bfd section macros and functions like bfd_section_size() has been | |||
configure.ac
Outdated
| @@ -212,6 +212,31 @@ AC_CHECK_FUNCS([ \ | |||
| strsignal \ | |||
| ]) | |||
|
|
|||
| dnl Various bfd section macros and functions like bfd_section_size() has been | |||
| dnl modified starting binutils >= 2.34. | |||
configure.ac
Outdated
| @@ -212,6 +212,31 @@ AC_CHECK_FUNCS([ \ | |||
| strsignal \ | |||
| ]) | |||
|
|
|||
| dnl Various bfd section macros and functions like bfd_section_size() has been | |||
| dnl modified starting binutils >= 2.34. | |||
| dnl Check if the prototype is "bfd_section_size (sec)" or "bfd_section_size(bfd, ptr)" | |||
There was a problem hiding this comment.
"Check if the prototypes take a bfd argument."
The latest Binutils release (2.34) is not compatible with elf2flt due to a change in bfd_section_* macros [1]. The issue has been reported to the Binutils mailing list but Alan Modra recommend to bundle libbfd library sources into each projects using it [2]. That's because the API is not stable over the time without any backward compatibility guaranties. On the other hand, the elf2flt tools needs to support modified version of binutils for specific arch/target [3]. Add two tests in the configure script to detect this API change in order to support binutils < 2.34 and binutils >= 2.34. Upstream status: [4] [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4 [2] https://sourceware.org/ml/binutils/2020-02/msg00044.html [3] uclinux-dev#14 [4] uclinux-dev#15 Signed-off-by: Romain Naour <romain.naour@smile.fr>
RomainNaour
force-pushed
the
check-binutils-2.34-api-change
branch
from
fa0e77a
to
2616590
Compare
|
were you planning on refreshing this ? |
atishp04
pushed a commit
to atishp04/elf2flt
that referenced
this pull request
Sep 29, 2021
The latest Binutils release (2.34) is not compatible with elf2flt due to a change in bfd_section_* macros [1]. The issue has been reported to the Binutils mailing list but Alan Modra recommend to bundle libbfd library sources into each projects using it [2]. That's because the API is not stable over the time without any backward compatibility guaranties. On the other hand, the elf2flt tools needs to support modified version of binutils for specific arch/target [3]. Add two tests in the configure script to detect this API change in order to support binutils < 2.34 and binutils >= 2.34. Upstream status: [4] [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4 [2] https://sourceware.org/ml/binutils/2020-02/msg00044.html [3] uclinux-dev#14 [4] uclinux-dev#15 Signed-off-by: Romain Naour <romain.naour@smile.fr>
damien-lemoal
pushed a commit
to damien-lemoal/elf2flt
that referenced
this pull request
Apr 21, 2022
The latest Binutils release (2.34) is not compatible with elf2flt due to a change in bfd_section_* macros [1]. The issue has been reported to the Binutils mailing list but Alan Modra recommend to bundle libbfd library sources into each projects using it [2]. That's because the API is not stable over the time without any backward compatibility guaranties. On the other hand, the elf2flt tools needs to support modified version of binutils for specific arch/target [3]. Add two tests in the configure script to detect this API change in order to support binutils < 2.34 and binutils >= 2.34. Upstream status: [4] [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4 [2] https://sourceware.org/ml/binutils/2020-02/msg00044.html [3] uclinux-dev#14 [4] uclinux-dev#15 Signed-off-by: Romain Naour <romain.naour@smile.fr>
michael131468
pushed a commit
to michael131468/elf2flt
that referenced
this pull request
Jul 5, 2022
The latest Binutils release (2.34) is not compatible with elf2flt due to a change in bfd_section_* macros [1]. The issue has been reported to the Binutils mailing list but Alan Modra recommend to bundle libbfd library sources into each projects using it [2]. That's because the API is not stable over the time without any backward compatibility guaranties. On the other hand, the elf2flt tools needs to support modified version of binutils for specific arch/target [3]. Add two tests in the configure script to detect this API change in order to support binutils < 2.34 and binutils >= 2.34. Upstream status: [4] [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4 [2] https://sourceware.org/ml/binutils/2020-02/msg00044.html [3] uclinux-dev#14 [4] uclinux-dev#15 Signed-off-by: Romain Naour <romain.naour@smile.fr>
|
This looks to have been sitting here for quite a while now. I have manually resolved the conflict, so it is at least clean and ready to be applied. As far as I can tell Romain addressed all feedback. |
|
tbh, i didn't really notice the updated pushes since the open comments weren't marked resolved, so was waiting for OP to do so. if you think issues are resolved, and you've rebased the work, then let's merge it. should update the unittest coverage (i.e. uclinux-dev/prebuilts-binutils-libs) to make sure things work & stay working. |
|
Further testing has found at least one problem. This only works if you use the single --with-binutils-build-dir configure form. If you specify each of the --with-libbfd/--with-libiberty/etc configure options (but no --with-binutils-build-dir option) it will fail to detect the version of binutils correctly. |
|
Oh, and the in-tree configure script needs to be regenerated too. |
|
hmm, we should add those scenarios to our CI tests |
gregungerer
pushed a commit
that referenced
this pull request
Apr 4, 2023
The latest Binutils release (2.34) is not compatible with elf2flt due to a change in bfd_section_* macros [1]. The issue has been reported to the Binutils mailing list but Alan Modra recommend to bundle libbfd library sources into each projects using it [2]. That's because the API is not stable over the time without any backward compatibility guaranties. On the other hand, the elf2flt tools needs to support modified version of binutils for specific arch/target [3]. Add two tests in the configure script to detect this API change in order to support binutils < 2.34 and binutils >= 2.34. Upstream status: [4] [1] https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fd3619828e94a24a92cddec42cbc0ab33352eeb4 [2] https://sourceware.org/ml/binutils/2020-02/msg00044.html [3] #14 [4] #15 Signed-off-by: Romain Naour <romain.naour@smile.fr> Two changes made to original patch: . $binutils_include_dir used for binutils version check . configure script regenerated (run autoconf) Signed-off-by: Greg Ungerer <gerg@kernel.org>
|
This pull request updated to fix --with-binutils-build-dir case and the configure script re-generated and applied to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest Binutils release (2.34) is not compatible with elf2flt due
to a change in bfd_section_* macros. The issue has been reported to
the Binutils mailing list but Alan Modra recommend to bundle libbfd
library sources into each projects using it [1]. That's because the
API is not stable over the time without any backward compatibility
guaranties.
On the other hand, the elf2flt tools needs to support modified
version of binutils for specific arch/target [2].
Add two tests in the configure script to detect this API change
in order to support binutils < 2.34 and binutils >= 2.34.
[1] https://sourceware.org/ml/binutils/2020-02/msg00044.html
[2] #14
Signed-off-by: Romain Naour romain.naour@smile.fr