Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use opj_image_data_free instead of opj_free for image->comps[].data #1014

Closed
trylab opened this issue Sep 8, 2017 · 1 comment
Closed

Use opj_image_data_free instead of opj_free for image->comps[].data #1014

trylab opened this issue Sep 8, 2017 · 1 comment

Comments

@trylab
Copy link
Contributor

trylab commented Sep 8, 2017 •
edited
Loading

Currently, mismatches have been found in the following files:

  • src/lib/openjp2/image.c
  • src/lib/openjp2/jp2.c
  • src/lib/openmj2/jp2.c

This may lead to crash on Windows as described in 61fb5dd

BTW, I don't know if openjp3d, openjpip, or openjpwl have same problems.
My patch could address issues in openjp2 and openmj2.
This was referenced Sep 8, 2017
Closed
Closed
rouault added a commit that referenced this issue Sep 8, 2017
@rouault
Use opj_image_data_free() where appropriate (adapted from dab9db0, #1014
b73ce71 
)
@rouault
Copy link
Collaborator

rouault commented Sep 8, 2017

I left apart the openmj2 case since this lib wasn't really touched. It has currently a dummy opj_image_data_malloc/free implementation that just redirects to standard malloc/free

@rouault rouault closed this as completed Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rouault @trylab