Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprintf buffer overflow #1085

Closed
setharnold opened this issue Feb 22, 2018 · 0 comments · Fixed by #1101
Closed

sprintf buffer overflow #1085

setharnold opened this issue Feb 22, 2018 · 0 comments · Fixed by #1101

Comments

@setharnold
Copy link
Contributor

openjpeg/src/bin/jp3d/convert.c

Line 791 in 06f7d41

sprintf(name, "%s.img", outfile); 

 sprintf(name, "%s.img", outfile);

Hello, I believe this allows overflowing the name array with the contents of outfile.

Thanks
kbabioch added a commit to kbabioch/openjpeg that referenced this issue Mar 3, 2018
@kbabioch
jp3d: Replace sprintf() by snprintf() in volumetobin()
e351c22 
This replaces the unsafe sprintf() invocation by the safer snprintf()
one, with the correct buffer size to prevent buffer overflows.

This fixes uclouvain#1085.
@kbabioch kbabioch mentioned this issue Mar 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

jp3d: Replace sprintf() by snprintf() in volumetobin() kbabioch/openjpeg
1 participant
@setharnold