OSX build gives libopenjp2.6.dylib with not-absolute install name id

[gcode-importer]

Originally reported on Google Code with ID 367

What steps will reproduce the problem?

1. Download openjpeg-2.0.0.tar.gz
2. tar zxvf openjpeg-2.0.0.tar.gz && cd openjpeg-2.0.0
3. cmake .  && make
4. DESTDIR=/Users/mb312/tmp/junk make install
5. otool -D /Users/mb312/tmp/junk/usr/local/lib/libopenjp2.2.0.0.dylib

What is the expected output? What do you see instead?

The command above gives the 'install_name_id'.  This generally gives the path location
of the library for other libraries to link against.  For example here is the output
of ``otool -L /usr/local/lib/libjpeg.dylib ``:

    /usr/local/lib/libjpeg.dylib:
    /usr/local/lib/libjpeg.8.dylib (compatibility version 13.0.0, current version 13.0.0)

So, for the command (5) above, I expect to see this:

    /Users/mb312/tmp/junk/usr/local/lib/libopenjp2.2.0.0.dylib:
        /Users/mb312/tmp/junk/usr/local/lib/libopenjp2.6.dylib (compatibility version
6.0.0, current version 2.0.0)

but in fact I see:

    /Users/mb312/tmp/junk/usr/local/lib/libopenjp2.2.0.0.dylib:
    libopenjp2.6.dylib (compatibility version 6.0.0, current version 2.0.0)

Notice the library filename rather than the library path as the 'install_name_id'.
Code linking against this library will put this path into to a generated dynamic library
as the path at which to find the library at run-time, and therefore the openjpeg library
will either have to be in the current directory of the running process or will not
be found at run-time.

I notice that the install_name_id is correctly set before 'make install'  Here ``otool
-D  bin/libopenjp2.6.dylib``: 

   bin/libopenjp2.6.dylib:
   /Users/mb312/tmp/openjpeg/openjpeg-2.0.0/bin/libopenjp2.6.dylib

What version of the product are you using? On what operating system?

OpenJPEG 2.0.0 on OSX 10.9.3

Please provide any additional information below.

Reported by matthew.brett on 2014-06-30 10:53:46

[gcode-importer]

This seems to be a long-standing deficiency in cmake: libtool automatically sets the
install_name correctly based on the prefix defined at compile-time, but instead authors
have to manually insert some boilerplate/magic for INSTALL_NAME_DIR in some CMakeLists.txt
or .cmake file

Reported by dmacks on 2014-08-29 03:56:27

[gcode-importer]

2.1.0 is the same (though it's libopenjp2.7.dylib not 2.6), and it's also the same problematic
result in the prebuilt binary download (openjpeg-2.1.0-Darwin-i386.tar.gz)

Reported by dmacks on 2014-08-29 04:05:48

[gcode-importer]

Reproduced on my side.
I will provide a patch for this.

BTW, you shouldn't see /Users/mb312/tmp/junk/usr/local/lib/libopenjp2.6.dylib but
/usr/local/lib/libopenjp2.6.dylib.
DESTDIR is only used as a staging directory. if you want to change the prefix, you
shall set CMAKE_INSTALL_PREFIX when configuring your build.

Reported by mayeut on 2014-09-18 09:24:04

• Status changed: Accepted

[gcode-importer]

Reported by mayeut on 2014-09-18 09:24:19

[gcode-importer]

Provided patch shows the following output :
make

otool -D ./bin/libopenjp2.dylib 
./bin/libopenjp2.dylib:
/Users/Matt/Dev/OpenJpeg/issue367/build/bin/libopenjp2.7.dylib

otool -L ./bin/opj_compress 
./bin/opj_compress:
    /Users/Matt/Dev/OpenJpeg/issue367/build/bin/libopenjp2.7.dylib (compatibility version
7.0.0, current version 2.1.0)
    /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

DESTDIR=/Users/Matt/Dev/OpenJpeg/issue367/build/bin/install make install

otool -D ./bin/install/usr/local/lib/libopenjp2.dylib 
./bin/install/usr/local/lib/libopenjp2.dylib:
/usr/local/lib/libopenjp2.7.dylib

otool -L ./bin/install/usr/local/bin/opj_compress 
./bin/install/usr/local/bin/opj_compress:
    /usr/local/lib/libopenjp2.7.dylib (compatibility version 7.0.0, current version 2.1.0)
    /usr/lib/libz.1.dylib (compatibility version 1.0.0, current version 1.2.5)
    /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1197.1.1)

The patch only affects APPLE builds
Tested against test suite & report in CDash

Reported by mayeut on 2014-09-18 21:02:19

• Status changed: Verified

---

- _Attachment: [issue367.patch](https://storage.googleapis.com/google-code-attachments/openjpeg/issue-367/comment-5/issue367.patch)_

[gcode-importer]

This issue was closed by revision r2882.

Reported by detonin on 2014-09-19 09:30:17

• Status changed: Fixed