Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor j2k_read_ppm_v3 function #470

Closed
gcode-importer opened this issue Jan 15, 2015 · 1 comment
Closed

Refactor j2k_read_ppm_v3 function #470

gcode-importer opened this issue Jan 15, 2015 · 1 comment
Assignees
Milestone

Comments

@gcode-importer
Copy link

Originally reported on Google Code with ID 470

While fixing issue 392, it appeared that function j2k_read_ppm_v3 should be refactored
(and renamed) in the following way : 

while reading the MH (in opj_j2k_read_header_procedure), concatenate all Nppm and corresponding
Ippm's and parse them all at once, once getting out of the while loop of the MH processing.
This would allow the processing of ppm data in the right order (if by any chance Zppm
are not in increasing order) and would avoid the need of adding a parameter to all
marker handlers to fix the ASan error with x64 (see issue 392).

Sanity checks at
https://code.google.com/p/openjpeg/source/browse/trunk/src/lib/openjp2/j2k.c?r=2963#3600
https://code.google.com/p/openjpeg/source/browse/trunk/src/lib/openjp2/j2k.c?r=2963#3644
might need to be removed too.


Reported by detonin on 2015-01-15 17:39:06

@mayeut
Copy link
Collaborator

mayeut commented Jul 11, 2015

j2k_read_ppt shall probably be refactored as well

mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 12, 2015
mayeut added a commit to mayeut/openjpeg that referenced this issue Jul 12, 2015
@mayeut mayeut closed this as completed in 28c6f54 Jul 20, 2015
@mayeut mayeut added this to the OPJ v2.1.1 milestone Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants