Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmj2/opj_includes.h: Do not define 'lrintf' on MSVC since 16.9.2 #1339

Closed
wants to merge 1 commit into from
Closed

openmj2/opj_includes.h: Do not define 'lrintf' on MSVC since 16.9.2 #1339

wants to merge 1 commit into from

Conversation

emmenlau
Copy link

@emmenlau emmenlau commented Mar 24, 2021 •
edited

This PR adds a minor fix for building with Visual Studio 16.9 ore newer. The newer versions have a builtin lrintf, so the current code was giving error:

[...]\src\lib\openmj2\opj_includes.h(97): error C2169: 'lrintf': intrinsic function, cannot be defined

This PR closes #1333

@emmenlau
Copy link
Author

emmenlau commented Apr 9, 2021

Is there something I can do to help move this forward?

@emmenlau emmenlau mentioned this pull request Apr 27, 2021
Closed
@rouault
Copy link
Collaborator

rouault commented Apr 27, 2021

Is there something I can do to help move this forward?

solve the CI breakage (unrelated to your commit admitedly)
http://kakadusoftware.com/wp-content/uploads/2014/06/KDU77_Demo_Apps* files are no longer available but I see http://kakadusoftware.com/wp-content/uploads/KDU805_Demo* files in http://kakadusoftware.com/wp-content/uploads/

Do you make an active use of openmj2 ? I mean besides just trying to compile it. It seems to me that the community behind it is clause to 0

@emmenlau
Copy link
Author

Is there something I can do to help move this forward?

solve the CI breakage (unrelated to your commit admitedly)
http://kakadusoftware.com/wp-content/uploads/2014/06/KDU77_Demo_Apps* files are no longer available but I see http://kakadusoftware.com/wp-content/uploads/KDU805_Demo* files in http://kakadusoftware.com/wp-content/uploads/

Do you make an active use of openmj2 ? I mean besides just trying to compile it. It seems to me that the community behind it is clause to 0

I'm not using it at all, that is very true. So I'm fine to leave this PR here hanging until the CI is solved. But it would be sad to just trash the PR, after we have it now...

@rouault
Copy link
Collaborator

rouault commented May 6, 2021

PR no longer relevant since #1350

@rouault rouault closed this May 6, 2021
@nist-anka nist-anka mentioned this pull request Aug 12, 2021
Merged
dabrain34 pushed a commit to dabrain34/openjpeg that referenced this pull request Oct 25, 2021
Remove unmaintained JPWL, JP3D and MJ2
3560d2b 
Since
uclouvain@85a87cd
the components JPWL, JP3d and MJ2 are not
maintained.
As win32 build was facing an issue with  mj2 and lrintf inline,
see  uclouvain#1339
Better to remove these useles componentes who will be removed
in v2.5.0.
dabrain34 pushed a commit to dabrain34/openjpeg that referenced this pull request Oct 25, 2021
Remove unmaintained JPWL, JP3D and MJ2
20da21a 
Since uclouvain#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain#1339), better
to remove these useles components who will be removed in v2.5.0.
dabrain34 pushed a commit to dabrain34/wrapdb that referenced this pull request Oct 25, 2021
Remove unmaintained JPWL, JP3D and MJ2
7521ef2 
Since uclouvain/openjpeg#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain/openjpeg#1339), better
to remove these useles components who will be removed in v2.5.0.
dabrain34 pushed a commit to dabrain34/wrapdb that referenced this pull request Oct 25, 2021
Remove unmaintained JPWL, JP3D and MJ2
d5eb510 
Since uclouvain/openjpeg#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain/openjpeg#1339), better
to remove these useles components who will be removed in v2.5.0.
@dabrain34 dabrain34 mentioned this pull request Oct 25, 2021
Merged
dabrain34 pushed a commit to dabrain34/wrapdb that referenced this pull request Oct 25, 2021
Remove unmaintained JPWL, JP3D and MJ2
8359b67 
Since uclouvain/openjpeg#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain/openjpeg#1339), better
to remove these useles components who will be removed in v2.5.0.
dabrain34 pushed a commit to dabrain34/wrapdb that referenced this pull request Oct 29, 2021
Remove unmaintained JPWL, JP3D and MJ2
4182507 
Since uclouvain/openjpeg#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain/openjpeg#1339), better
to remove these useles components who will be removed in v2.5.0.
dabrain34 pushed a commit to dabrain34/wrapdb that referenced this pull request Sep 5, 2022
@dabrain34
Remove unmaintained JPWL, JP3D and MJ2
8856007 
Since uclouvain/openjpeg#1350
the components JPWL, JP3d and MJ2 will not be
maintained in 2.5.0.

As win32 build was facing an issue with mj2 build and lrintf inline,
(see  uclouvain/openjpeg#1339), better
to remove these useles components who will be removed in v2.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error C2169: 'lrintf': intrinsic function, cannot be defined
2 participants
@emmenlau @rouault