Fix some typos (found by codespell) #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Weil <sw@weilnetz.de>
stweil
commented
Dec 5, 2021
src/lib/openjp2/j2k.c
Outdated
| @@ -8829,7 +8829,7 @@ static OPJ_BOOL opj_j2k_read_header_procedure(opj_j2k_t *p_j2k, | |||
| if (l_marker_handler->id == J2K_MS_UNK) { | |||
| if (! opj_j2k_read_unk(p_j2k, p_stream, &l_current_marker, p_manager)) { | |||
| opj_event_msg(p_manager, EVT_ERROR, | |||
| "Unknow marker have been detected and generated error.\n"); | |||
| "Unknown marker have been detected and generated error.\n"); | |||
There was a problem hiding this comment.
This looks also like a singular / plural mismatch. Should it be markers have or marker has?
|
the astyle check fails because you've touched files that weren't compliant with it before. Would you mind running astyle on them first to have a reindent-only commit, and then fix the typos in a separate commit ? |
|
Would it be also okay to add the astyle commit after the typo fixes (which required some manual work)? |
Signed-off-by: Stefan Weil <sw@weilnetz.de>
yeah, that can do it too |
Signed-off-by: Stefan Weil <sw@weilnetz.de>
|
Only a single source file had to be re-formatted (done in 3rd commit). |
stweil
commented
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Weil sw@weilnetz.de