Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow in num_images #1395

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Fix integer overflow in num_images #1395

merged 1 commit into from
Jan 12, 2022

Conversation

baparham
Copy link
Contributor

Includes the fix for CVE-2021-29338
Credit to @kaniini based on #1346
Fixes #1338

@baparham
Copy link
Contributor Author

It's not clear to me if the OPJ_PATH_LEN * 2 changes from #1346 are also necessary since f0629cb was merged into master. Can you help confirm @rouault ?

@rouault
Copy link
Collaborator

rouault commented Jan 12, 2022

It's not clear to me if the OPJ_PATH_LEN * 2 changes from #1346 are also necessary since f0629cb was merged into master. Can you help confirm @rouault ?

I don't think they are necessary since we have other checks that should prevent buffer overflow

@rouault rouault merged commit 79c7d7a into uclouvain:master Jan 12, 2022
@kaniini
Copy link

kaniini commented Jan 12, 2022

Thanks for taking care of this @baparham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integer Overflow in num_images
3 participants
@baparham @rouault @kaniini