Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Suspicious code in j2k.c #517 #529

Merged
merged 1 commit into from
Jul 12, 2015
Merged

Conversation

renevanderark
Copy link

Okay, so this is my very first pull request, removing the apparently superfluous call in line 10024 opj_alloc_tile_component_data(l_tilec);

I tested this manually and reran the regression tests encountering no apparent differences. Please be gentle on feedback as I'm quite new to collaborating on github.

@renevanderark
Copy link
Author

As requested I'm adding a before and after test result, both showing 33 failures (on xubuntu 14.04 LTS):

Before:

97% tests passed, 33 tests failed out of 988

Total Test time (real) = 192.60 sec

The following tests FAILED:
96 - ETS-JP2-file5.jp2-decode (Failed)
97 - ETS-JP2-file5.jp2-compare2ref (Failed)
98 - NR-JP2-file5.jp2-compare2base (Failed)
102 - ETS-JP2-file7.jp2-decode (Failed)
103 - ETS-JP2-file7.jp2-compare2ref (Failed)
104 - NR-JP2-file7.jp2-compare2base (Failed)
106 - ETS-JP2-file8.jp2-compare2ref (Failed)
107 - NR-JP2-file8.jp2-compare2base (Failed)
127 - ETS-KDU-a6_mono_colr.j2c-compare2ref (Failed)
128 - NR-KDU-a6_mono_colr.j2c-compare2base (Failed)
168 - ETS-KDU-g3_colr.j2c-decode (Failed)
169 - ETS-KDU-g3_colr.j2c-compare2ref (Failed)
170 - NR-KDU-g3_colr.j2c-compare2base (Failed)
172 - ETS-KDU-g4_colr.j2c-compare2ref (Failed)
173 - NR-KDU-g4_colr.j2c-compare2base (Failed)
663 - NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dump2base (Failed)
665 - NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dec-ref-out2base (Failed)
668 - NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dump2base (Failed)
670 - NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dec-ref-out2base (Failed)
693 - NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dump2base (Failed)
695 - NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dec-ref-out2base (Failed)
762 - NR-DEC-issue104_jpxstream.jp2-33-decode-md5 (Failed)
807 - NR-DEC-issue135.j2k-68-decode-md5 (Failed)
813 - NR-DEC-issue171.jp2-71-decode-md5 (Failed)
815 - NR-DEC-broken.jpc-73-decode (Failed)
816 - NR-DEC-issue226.j2k-74-decode (Failed)
817 - NR-DEC-issue226.j2k-74-decode-md5 (Failed)
940 - NR-DEC-p1_06.j2k-156-decode (Failed)
941 - NR-DEC-p1_06.j2k-156-decode-md5 (Failed)
956 - NR-DEC-p1_06.j2k-164-decode (Failed)
957 - NR-DEC-p1_06.j2k-164-decode-md5 (Failed)
984 - Found-But-No-Test-v4dwt_interleave_h.gsr105.j2k (Failed)
985 - Found-But-No-Test-dwt_interleave_h.gsr105.jp2 (Failed)

After:

97% tests passed, 33 tests failed out of 988

Total Test time (real) = 190.06 sec

The following tests FAILED:
96 - ETS-JP2-file5.jp2-decode (Failed)
97 - ETS-JP2-file5.jp2-compare2ref (Failed)
98 - NR-JP2-file5.jp2-compare2base (Failed)
102 - ETS-JP2-file7.jp2-decode (Failed)
103 - ETS-JP2-file7.jp2-compare2ref (Failed)
104 - NR-JP2-file7.jp2-compare2base (Failed)
106 - ETS-JP2-file8.jp2-compare2ref (Failed)
107 - NR-JP2-file8.jp2-compare2base (Failed)
127 - ETS-KDU-a6_mono_colr.j2c-compare2ref (Failed)
128 - NR-KDU-a6_mono_colr.j2c-compare2base (Failed)
168 - ETS-KDU-g3_colr.j2c-decode (Failed)
169 - ETS-KDU-g3_colr.j2c-compare2ref (Failed)
170 - NR-KDU-g3_colr.j2c-compare2base (Failed)
172 - ETS-KDU-g4_colr.j2c-compare2ref (Failed)
173 - NR-KDU-g4_colr.j2c-compare2base (Failed)
663 - NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dump2base (Failed)
665 - NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dec-ref-out2base (Failed)
668 - NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dump2base (Failed)
670 - NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dec-ref-out2base (Failed)
693 - NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dump2base (Failed)
695 - NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dec-ref-out2base (Failed)
762 - NR-DEC-issue104_jpxstream.jp2-33-decode-md5 (Failed)
807 - NR-DEC-issue135.j2k-68-decode-md5 (Failed)
813 - NR-DEC-issue171.jp2-71-decode-md5 (Failed)
815 - NR-DEC-broken.jpc-73-decode (Failed)
816 - NR-DEC-issue226.j2k-74-decode (Failed)
817 - NR-DEC-issue226.j2k-74-decode-md5 (Failed)
940 - NR-DEC-p1_06.j2k-156-decode (Failed)
941 - NR-DEC-p1_06.j2k-156-decode-md5 (Failed)
956 - NR-DEC-p1_06.j2k-164-decode (Failed)
957 - NR-DEC-p1_06.j2k-164-decode-md5 (Failed)
984 - Found-But-No-Test-v4dwt_interleave_h.gsr105.j2k (Failed)
985 - Found-But-No-Test-dwt_interleave_h.gsr105.jp2 (Failed)

mayeut added a commit that referenced this pull request Jul 12, 2015
fix Suspicious code in j2k.c
Fixes #517
@mayeut mayeut merged commit 0b1f8eb into uclouvain:master Jul 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants