Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add COC/QCC in main header when needed #551

Merged
merged 11 commits into from
Jan 10, 2016
Merged

Conversation

mayeut
Copy link
Collaborator

@mayeut mayeut commented Jul 29, 2015

Update #459

@malaterre
Copy link
Collaborator

Can we get a little bit more info about this ? Maybe a small unit test that exhibit the issue ? Or is this solved as mentionned in #459 with PR #8 ?

@mayeut
Copy link
Collaborator Author

mayeut commented Jan 9, 2016

@malaterre, there's already test cases in the test suite for this as mentioned in #459 & data with uclouvain/openjpeg-data#8:
NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dump2base
NR-ENC-issue203-32x32-bgr16.bmp-43-compare_dec-ref-out2base
NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dump2base
NR-ENC-issue203-33x33-bgr16.bmp-44-compare_dec-ref-out2base
NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dump2base
NR-ENC-issue203-127x64-bgr16.bmp-49-compare_dec-ref-out2base

The tests are now ok with this PR

basically what it does:
When when setting up main header writing in opj_j2k_setup_header_writing, add new procedures that will write COC/QCC. Those procedures will only write something if COC/QCC is different from COD/QCD so that there's no regression with previous implementation for normal cases.

mayeut added a commit that referenced this pull request Jan 10, 2016
Add COC/QCC in main header when needed
@mayeut mayeut merged commit a42d03d into uclouvain:master Jan 10, 2016
@mayeut mayeut deleted the coc-qcc branch January 10, 2016 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants